On 17 August 2016 at 19:57, Michal Privoznik <mpriv...@redhat.com> wrote: > On 17.08.2016 17:28, Laurent Vivier wrote: >> Le 17/08/2016 à 15:49, Michal Privoznik a écrit : >>> In 9c37146782 I've tried to fix a broken build with older >>> linux-headers. However, I didn't do it properly. The solution >>> implemented here is to grab the enums that caused the problem >>> initially, and rename their values so that they are "QEMU_" >>> prefixed. In order to guarantee matching values with actual >>> enums from linux-headers, the enums are seeded with starting >>> values from the original enums. >>> >>> Signed-off-by: Michal Privoznik <mpriv...@redhat.com> >> >> I don't think you need the "QEMU_IFLA_XXX_UNSPEC = IFLA_XXX_UNSPEC" >> part as IFLA_XXX_UNSPEC is always 0 and enums always start at 0. > > Correct, I just wanted to make it clear that these enums I'm introducing > here are the same as IFLA_*. But I don't have a strong opinion on that, > so whatever you prefer.
I think it's better without them, as then we're entirely independent of whether the system headers define any of these constants at all. Could you respin without those, please? thanks -- PMM
