On Tue, 2010-08-03 at 08:17 -0400, Glauber Costa wrote: > On Mon, Aug 02, 2010 at 03:15:17PM -0600, Alex Williamson wrote: > > When we hotplug the device, > > we don't go through a reset cycle, which means a hot added e1000 is > > useless until the VM reboots. > > I do guess, however, that this is true for any device, right? > > Wouldn't it be better to just call the newly added reset function at > hotplug? One way to do that, would be to store a value indicated qemu > has already started. If you add a reset handler after that, the function > is called before being placed on the list.
Yeah, that sounds like a better idea. We can actually do it quite easily from qdev_init using the hotplugged flag on the DeviceState. Drop this e1000 specific one, I'll send a new patch in a minute. Thanks, Alex
