On 16 August 2016 at 18:28, Laurent Vivier <laur...@vivier.eu> wrote: > > > Le 16/08/2016 à 18:51, Peter Maydell a écrit : >> The best approach I can think of is to add something at the >> top of syscall.c that does: >> #if IFLA_BR_MAX < 9 >> #define IFLA_BR_GROUP_FWD_MASK 9 >> #endif >> #if IFLA_BR_MAX < 10 >> #define IFLA_BR_ROOT_ID 10 >> #endif >> etc etc >> >> and then we can unconditionally use the symbols in the switches. >> >> Anybody got a better idea? > > Perhaps we can define our own enum with all the known values at the > moment, something like QEMU_IFLA_BR_XXX?
Yes, that's probably better (we usually call those TARGET_FOO rather than QEMU_FOO). Or we could follow what linux-user/linux_loop.h does, though I don't much like that approach. thanks -- PMM