Am 15.08.2016 um 03:49 hat Changlong Xie geschrieben:
> On 08/09/2016 05:08 PM, Kevin Wolf wrote:
> >Am 27.07.2016 um 09:01 hat Changlong Xie geschrieben:
> >>From: Wen Congyang <we...@cn.fujitsu.com>
> >>
> >>Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
> >>Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com>
> >>Signed-off-by: Wang WeiWei <wangww.f...@cn.fujitsu.com>
> >>Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
> >>Signed-off-by: Gonglei <arei.gong...@huawei.com>
> >>Reviewed-by: Eric Blake <ebl...@redhat.com>
> >
> >>@@ -2078,6 +2079,23 @@
> >> { 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] }
> >>
> >> ##
> >>+# @BlockdevOptionsReplication
> >>+#
> >>+# Driver specific block device options for replication
> >>+#
> >>+# @mode: the replication mode
> >>+#
> >>+# @top-id: #optional In secondary mode, node name or device ID of the root
> >>+# node who owns the replication node chain. Ignored in primary
> >>mode.
> >
> >Can we change this to "Must not be given in primary mode"? Not sure what
> >the code currently does, but I think it should error out if top-id is
>
> Replication driver will ignore "top-id" parameter in Primary mode.
This is not good behaviour, which is why I requested a change.
Kevin
> >given there.
> >
> >>+#
> >>+# Since: 2.8
> >>+##
> >>+{ 'struct': 'BlockdevOptionsReplication',
> >>+ 'base': 'BlockdevOptionsGenericFormat',
> >>+ 'data': { 'mode': 'ReplicationMode',
> >>+ '*top-id': 'str' } }
> >
> >Kevin
