On 08/02/2010 11:29 AM, Blue Swirl wrote:
Yeah, I'm neglecting the fact that we're not consistent as maintainers and
I'm all for dropping it from CODING_STYLE.
I'd rather expand the document. For example, I like the approach libvirt takes:
http://libvirt.org/git/?p=libvirt.git;a=blob_plain;f=HACKING;hb=HEAD
Not specifically to braces, but they describe types and memory
allocation etc. which is FAQ stuff for us too.
I agree 100%. There are a lot of idioms in QEMU that would be good to
document for people learning the code base.
But I think that's orthogonal to the discussion of whether we want to
keep the if rule and whether we want to enforce all of coding style at
commit time.
Regards,
Anthony Liguori
