Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

[Stefan Weil]

Am 02.08.2016 um 11:18 schrieb Fam Zheng:
[...]
> +void qemu_uuid_generate(qemu_uuid_t out)
> +{
> +    /* Version 4 UUID, RFC4122 4.4. */
> +    QEMU_BUILD_BUG_ON(sizeof(qemu_uuid_t) != 16);
> +    *((guint32 *)out + 0) = g_random_int();
> +    *((guint32 *)out + 1) = g_random_int();
> +    *((guint32 *)out + 2) = g_random_int();
> +    *((guint32 *)out + 3) = g_random_int();

I suggest using uint32_t instead of guint32.
Up to now, nearly all QEMU code uses the POSIX data types.

Regards
Stefan