On 4 August 2016 at 19:49, John Snow <js...@redhat.com> wrote: > > > On 08/04/2016 02:46 PM, Peter Maydell wrote: >> (2) declare that size == 0 is not valid and make it return a failure >> code back down the qtest pipe (and fix the offending tests) >> > > This is probably the nicer thing to do -- if memset of length 0 is > undefined, probably qmemset and friends should also be undefined by > extension.
That was my thought. > I reserve the right to change my mind depending on how gnarly it is to > untangle. > > I assume you're hoping for 2.7. I dunno. If the patch turns out easy we can put it in 2.7. But it's only test code and it's been working fine for a long time til we noticed it, so I don't think it matters if we let it slide til 2.8. thanks -- PMM