Re: [Qemu-devel] [PATCH v1 2/5] target-ppc: add vector extract instructions

[Richard Henderson]

On 08/04/2016 06:33 PM, Rajalakshmi Srinivasaraghavan wrote:

+#define VEXTRACT(suffix, element, index)                                     \
+    void helper_vextract##suffix(ppc_avr_t *r, ppc_avr_t *b, uint32_t splat) \
+    {                                                                        \
+        int i;                                                               \
+                                                                             \
+        for (i = 0; i < ARRAY_SIZE(r->element); i++) {                       \
+            r->element[i] = 0;                                               \
+        }                                                                    \
+        memcpy(&r->element[index], &b->u8[SPLAT_ELEMENT(u8)],                \
+               sizeof(r->element[0]));                                       \
+    }

You're not caring for R == B.


r~