On 08/02/2016 01:17 AM, Bruce Rogers wrote:
Hi Cao,
Upon re-reading your comment, I believe you are still thinking that
it was right to use the error object in this context. The fact that this
device has no pin interrupt is _not_ an error condition, and hence the
use of error_setg() is not appropriate, and in fact causes Xen HVM PCI
passthrough to fail, when it would otherwise succeed.
Hi bruce,
Thanks for pointing it out, I didn't have much knowledge on this topic,
but you words buys me, I am fine with the patch.
This patch does not attempt to address any shortcomings with
XEN_PT_LOG, since it is still in use in many other places in this source
file.
hth,
Bruce
--
Yours Sincerely,
Cao jin
