Hi Peter, On 29/07/2016 15:35, Peter Maydell wrote: > On 6 July 2016 at 10:46, Eric Auger <eric.au...@redhat.com> wrote: >> +/** >> + * >> + * We currently do not use kvm_arm_register_device to provide >> + * the kernel with the vITS control frame base address since the >> + * KVM_DEV_ARM_VGIC_CTRL_INIT init MUST be called after the >> + * KVM_ARM_SET_DEVICE_ADDR and the kvm_arm_register_device >> + * infra does not allow this. >> + */ > > So the conclusion on the kvm-arm mailing list was that the > kernel ought to permit DEVICE_ADDR to be set after INIT, > the same way it does for the GIC proper, right? Yes this was indeed evoked but eventually what is in next, right now is the same implementation where KVM_ARM_SET_DEVICE_ADDR is forbidden once init is done:
see virt/kvm/arm/vgic/vgic-its.c its->initialized set by vgic_its_init_its (KVM_DEV_ARM_VGIC_GRP_CTRL) case KVM_DEV_ARM_VGIC_GRP_ADDR: ../.. if (its->initialized) return -EBUSY; Thanks Eric > > thanks > -- PMM >