On Wed, 2016-07-27 at 11:50 +1000, David Gibson wrote: > > > +void raise_exception_err(CPUPPCState *env, uint32_t exception, > > + uint32_t error_code) > > +{ > > + raise_exception_err_ra(env, exception, error_code, 0); > > +} > > + > > +void raise_exception(CPUPPCState *env, uint32_t exception) > > +{ > > + raise_exception_err_ra(env, exception, 0, 0); > > +} > > + > > +void raise_exception_ra(CPUPPCState *env, uint32_t exception, > > + uintptr_t raddr) > > +{ > > + raise_exception_err_ra(env, exception, 0, 0); > > This should pass raddr as the last argument, shouldn't it?
Yes. The fact that I didn't notice the breakage shows how few things actually care about those exceptions being precise ;-) I'll respin the patch. Thanks. Cheers, Ben.