Hi Peter, Thanks for your guidance!
> -----Original Message----- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Tuesday, July 26, 2016 5:23 PM > To: 이광우(LEE KWANGWOO) MS SW > Cc: Xiao Guangrong; Michael S. Tsirkin; Igor Mammedov; Paolo Bonzini; Richard > Henderson; Eduardo > Habkost; Shannon Zhao; Shannon Zhao; QEMU Developers; qemu-arm; 정우석(CHUNG WOO > SUK) MS SW; 김현철(KIM > HYUNCHUL) MS SW > Subject: Re: [RFC PATCH 3/3] hw/arm/virt: add nvdimm emulation support > > On 26 July 2016 at 08:03, kwangwoo....@sk.com <kwangwoo....@sk.com> wrote: > > Hi Peter, > > > > Please, check the comments below. Thanks a lot! > > > >> -----Original Message----- > >> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > >> This seems to be missing code to write the device tree > >> information about whatever this device is? > > > > Is it OK to just add a memory region which cannot be used without ACPI? > > This is unclear to me. If you suggest that it is better way, I'll revise > > this patch to add a device tree node. Please, help me to understand. > > They don't necessarily both have to be added in the exact same patch > if it's less confusing to split it, but the series as a whole > should support both DT and ACPI (and your kernel patches also > ought to have both DT and ACPI bindings I think). Although NVDIMM is dependent on ACPI NFIT table currently, I'll keep this comment in mind and revise it step by step. > thanks > -- PMM Best Regards, Kwangwoo Lee
