On Fri, Jul 22, 2016 at 8:16 PM, Eric Blake <ebl...@redhat.com> wrote: > On 07/22/2016 08:34 AM, Prasanna Kumar Kalever wrote: >> 1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-level/ >> 2. rearrange the versioning >> 3. s/server description/servers description/ >> >> Signed-off-by: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> > > This part is fine. > >> v2: address review comments given by Eric Blake >> v1: Initial patch > > But these lines... > >> --- > > ...should be here. They are useful to reviewers, but do not need to > clutter qemu.git, so putting them after the separator lets 'git am' > automatically strip them.
I learned this before :) This was not intentional Thanks, -- Prasanna > > The maintainer can probably fix that without needing a respin. > >> qapi/block-core.json | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > Must go in during hard freeze for 2.7, otherwise it would be an ABI > change compared to released code. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >
