On (Fri) Jul 23 2010 [15:08:18], Luiz Capitulino wrote:
> > diff --git a/monitor.c b/monitor.c
> > index 45fd482..d12a7b5 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -1056,6 +1056,10 @@ static int do_cont(Monitor *mon, const QDict *qdict,
> > QObject **ret_data)
> > {
> > struct bdrv_iterate_context context = { mon, 0 };
> >
> > + if (incoming_expected && !incoming_done) {
> > + autostart = 1;
>
> Why do we need to set autostart? We should just fail if we're unable to run.
>
> > + return 1; /* Waiting for incoming migration */
>
> You should return -1 and use qerror_report(), so that we have a meaningful
> error in the user Monitor and QMP (otherwise we'll get UndefinedError).
That would mean old/existing libvirt will be confused on why guests
wouldn't start even though it issued cont.
If it's not a problem for the libvirt folks, I can do that.
> And incomding_done is not needed.
Yes, not in this version.
Amit
