Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-img: add the 'dd' subcommand

[Stefan Hajnoczi]

On Tue, Jul 19, 2016 at 07:42:00AM +0200, Reda Sallahi wrote:
> +struct DdIo {
> +    size_t bsz;    /* Block size */
> +    off_t offset;

Oops, I did notice this.

No POSIX APIs with off_t are used.  Please use the QEMU block layer's
int64_t type instead.

Stefan

signature.asc
Description: PGP signature