Gerd Hoffmann <kra...@redhat.com> writes: > On Do, 2016-07-14 at 04:49 -0700, Isaac Lozano wrote: >> Added support for sending data larger than 4gb. > >> Also implemented >> object properties so that Windows can receive >4gb files. > > Can you please split those into two separate patches? > >> + case PROP_PERSISTENT_UNIQUE_OBJECT_IDENTIFIER: >> + /* Should be persistant between sessions, >> + * but using our objedt ID is "good enough" >> + * for now */ >> + usb_mtp_add_u64(d, 0x0000000000000000); >> + usb_mtp_add_u64(d, o->handle); >> + break; > > Maybe use the inode number here?
I think it was me who suggested putting in all 0s to him as more of a todo task :) The inode number should work here. > cheers, > Gerd
