Eric Blake <ebl...@redhat.com> writes: > On 07/14/2016 02:14 AM, Thomas Huth wrote: >> No need to include error-report.h twice here. >> >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> target-ppc/mmu-hash64.c | 1 - >> 1 file changed, 1 deletion(-) > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > Markus, do your header cleanup scripts detect any other situations like > this?
Not yet. Here's how I'd eliminate double inclusion. Step 1: make our own headers includable in any order. Step 2: include them in alphabetical order. The duplicates become obvious, and get dropped. Step 3: tell the lazy bums adding includes in the wrong place to mend their ways. I'm knee-deep in step 1.
