On 07/14/2016 07:33 AM, Denis V. Lunev wrote: > The code inside the helper will be extended in the next patch. mirror_run > itself is overbloated at the moment. > > Signed-off-by: Denis V. Lunev <d...@openvz.org> > Reviewed-by: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com> > Reviewed-by: Eric Blake <ebl...@redhat.com>
I did NOT give R-b on v2 3/7. In particular, this patch has semantic changes that I requested on v2, and so you want to make sure I re-review it (I often skip re-reviewing a patch that has my R-b listed, on the grounds that I'm trusting your judgment that it hasn't substantially changed since my last time through it; but here, you have changed it since last time). > Reviewed-by: Fam Zheng <f...@redhat.com> > CC: Stefan Hajnoczi <stefa...@redhat.com> > CC: Kevin Wolf <kw...@redhat.com> > CC: Max Reitz <mre...@redhat.com> > CC: Jeff Cody <jc...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > --- > block/mirror.c | 70 > ++++++++++++++++++++++++++++++++++------------------------ > 1 file changed, 41 insertions(+), 29 deletions(-) That said, I've looked through the changes (the rebase on top of moving last_pause_ns to being a member of s, so that a single timestamp is shared across both functions), and can now safely state: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
