On Tue, 12 Jul 2016 14:48:43 +0200 Igor Mammedov <imamm...@redhat.com> wrote:
> On Tue, 12 Jul 2016 00:29:08 -0300 > Eduardo Habkost <ehabk...@redhat.com> wrote: [...] > > 1) x86_cpu_realizefn(): > > if (cpu->env.features[FEAT_1_EDX] & CPUID_APIC || smp_cpus > 1) { > > x86_cpu_apic_create(cpu, &local_err); Usage of smp_cpus here looks incorrect to me, it should be max_cpus. But we can't make it max_cpus without compat glue as it will break backwards migration (not that upstream cares about it)