On Tue, 12 Jul 2016 13:19:55 +0800
Fam Zheng <f...@redhat.com> wrote:
> It always equals to assign now.
I think this needs further elaboration...
>
> Signed-off-by: Fam Zheng <f...@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
> ---
> hw/virtio/virtio-bus.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> @@ -167,7 +166,7 @@ static int set_host_notifier_internal(DeviceState *proxy,
> VirtioBusState *bus,
> error_report("%s: unable to init event notifier: %d", __func__,
> r);
> return r;
> }
> - virtio_queue_set_host_notifier_fd_handler(vq, true, set_handler);
> + virtio_queue_set_host_notifier_fd_handler(vq, true, true);
> r = k->ioeventfd_assign(proxy, notifier, n, assign);
> if (r < 0) {
> error_report("%s: unable to assign ioeventfd: %d", __func__, r);
> @@ -269,7 +268,7 @@ int virtio_bus_set_host_notifier(VirtioBusState *bus, int
> n, bool assign)
> */
> virtio_bus_stop_ioeventfd(bus);
> }
> - return set_host_notifier_internal(proxy, bus, n, assign, false);
> + return set_host_notifier_internal(proxy, bus, n, assign);
...because this changes the behaviour for assign==true.
> }
>
> static char *virtio_bus_get_dev_path(DeviceState *dev)
