On 05/07/2016 17:50, Kevin Wolf wrote:
> +};
> +
> +static int enable_write_target(BlockDriverState *bs, Error **errp)
> +{
> + BDRVVVFATState *s = bs->opaque;
> BlockDriver *bdrv_qcow = NULL;
> BlockDriverState *backing;
> QemuOpts *opts = NULL;
> @@ -3000,8 +3020,8 @@ static int enable_write_target(BDRVVVFATState *s, Error
> **errp)
>
> options = qdict_new();
> qdict_put(options, "driver", qstring_from_str("qcow"));
> - s->qcow = bdrv_open(s->qcow_filename, NULL, options,
> - BDRV_O_RDWR | BDRV_O_NO_FLUSH, errp);
> + s->qcow = bdrv_open_child(s->qcow_filename, options, "write-target", bs,
> + &child_vvfat_qcow, false, errp);
> if (!s->qcow) {
> ret = -EINVAL;
> goto err;
For whatever reason, Coverity now notices that the "options" QDict is
leaked. Who's right?
Paolo
