On 04.07.2016 12:58, Kevin Wolf wrote: > Am 02.07.2016 um 18:28 hat Max Reitz geschrieben: >> On 30.06.2016 16:13, Kevin Wolf wrote: >>> werror/rerror are now available as qdev options. The stats-* options are >>> removed without an existing replacement; they should probably be >>> configurable with a separate QMP command like I/O throttling settings. >> >> I'm not sure I agree with removing the stats-* options without a >> replacement. If we'd get rid of @id in the process, fine. But we won't >> get a pure blockdev-add before 2.7 anyway, so I'm not sure removing >> stats-* now is necessary. > > Actually, I'm not so sure about removing id only after 2.7. Basically > all that's missing is a conversion of block job commands to accept > node-name so that qemu-iotests cases can be converted. This is a mostly > mechanical conversion and I have part of it ready. > > About keeping stats-*, what good is it to keep an option that we know > will go away sooner or later? For id there is a good reason, removing it > now would break test cases. But stats-*? I don't see a reason.
The reason would be "If someone is insane enough to use blockdev-add and then wants to make use of those options". I guess your reason for removing it would be "Don't encourage such people further". Fine with me, then. Max
signature.asc
Description: OpenPGP digital signature
