On 30/06/2016 16:30, Markus Armbruster wrote: >>> >> + >>> >> +/* NOTE: May only be included into target-dependent code */ >> > >> > This shouldn't be true for cpu-qom.h. >> > >> > Perhaps >> > Paolo > Here's what made me mark the header: > > $ make tests/headers/target-sparc/cpu-qom.o > [...] > CC tests/headers/target-sparc/cpu-qom.o > In file included from tests/headers/target-sparc/cpu-qom.c:14:0: > /work/armbru/qemu/target-sparc/cpu-qom.h:28:8: error: attempt to use > poisoned "TARGET_SPARC64" > #ifdef TARGET_SPARC64 > ^ > /work/armbru/qemu/rules.mak:59: recipe for target > 'tests/headers/target-sparc/cpu-qom.o' failed > make: *** [tests/headers/target-sparc/cpu-qom.o] Error 1 > > Error context: > > #ifdef TARGET_SPARC64 > #define TYPE_SPARC_CPU "sparc64-cpu" > #else > #define TYPE_SPARC_CPU "sparc-cpu" > #endif
Good, this one is a FIXME then. :) Paolo
