On Fri, Jul 16, 2010 at 1:14 PM, Anthony Liguori <anth...@codemonkey.ws> wrote:
> On 07/16/2010 10:41 AM, Markus Armbruster wrote:
>>> A less invasive way to do this would be to chain netdev devices.
>>>
>>> Basically:
>>>
>>> -netdev tap,fd=X,id=foo
>>> -netdev dump,file=foo.pcap,netdev=foo,id=bar
>>> -net nic,model=virtio,netdev=bar
>>>
>>
>> Is this really less invasive? It breaks the simple 1:1 relationship
>> between NIC and network backend. All the code dealing with
>> VLANClientState member peer needs to be touched. For instance, this is
>> the code to connect peers, in qemu_new_net_client():
>>
>> if (peer) {
>> assert(!peer->peer);
>> vc->peer = peer;
>> peer->peer = vc;
>> }
>>
>
> The peering code should all disappear. I thought that's the whole point of
> this exercise?
>
My intent was to take small steps towards dropping the vlan code, and
one strong dependency for that is to have some facility equivalent to
dump.
For now I believe a solution as simple as possible would be better.
Regards,
Miguel
