On 06/28/2016 04:17 AM, Dr. David Alan Gilbert wrote: >> QmpInputVisitor is used to parse all QMP monitor commands, so will >> be used continuously throughout life of QEMU, often very frequently. >> eg When migration is running many monitor commands per second are >> expected > > Does the same input visitor get reused by each command?
No; in fact commit f2ff429 changed things to intentionally prevent reuse of a visitor (on the argument that it was easier to do that than to think about corner cases of reset after a partial visit encountered errors). But we can revisit that decision if reusing a static QmpInputVisitor would be wiser than allocating a fresh one for every visit. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
