On 27/06/2016 19:27, Sascha Silbe wrote: > Dear Markus, > > Markus Armbruster <arm...@redhat.com> writes: > >> Some time ago, we discussed rules for headers, and these were >> generally liked: > [...] >> Trouble is we're not exactly close to obeying 2. This series >> demonstrates a possible path towards obeying it: enforce it in "make >> check", except for known-bad headers [PATCH 2]. We start with a large >> list of known-bad headers, then whittle it down. Some sample >> whittling in PATCH 4+5. > [...] > > Does this series depend on any other series that's not in master yet? > > After applying your series on top of f12103af and running "./configure" > in a clean working directory, I get the following errors for "make > check-source": > > $ make check-source > egrep: config-host.h: No such file or directory > egrep: qmp-commands.h: No such file or directory > egrep: qapi-types.h: No such file or directory > egrep: qapi-visit.h: No such file or directory > egrep: qapi-event.h: No such file or directory > egrep: qmp-introspect.h: No such file or directory > egrep: trace/generated-events.h: No such file or directory > egrep: trace/generated-tracers.h: No such file or directory > egrep: trace/generated-tcg-tracers.h: No such file or directory > egrep: trace/generated-helpers-wrappers.h: No such file or directory > egrep: trace/generated-helpers.h: No such file or directory > egrep: tests/test-qapi-types.h: No such file or directory > egrep: tests/test-qapi-visit.h: No such file or directory > egrep: tests/test-qmp-commands.h: No such file or directory > egrep: tests/test-qapi-event.h: No such file or directory > egrep: tests/test-qmp-introspect.h: No such file or directory > GEN aarch64-softmmu/config-devices.mak.tmp > GEN aarch64-softmmu/config-devices.mak > [...] > GEN tests/test-qmp-introspect.h > make: *** No rule to make target `tests/headers/audio/audio.o', needed by > `check-headers'. Stop.
Hi Sascha, these are all generated headers. In general, "make check" must be run after "make", and I suppose the same holds for "make check-headers". Paolo
