fail_gd error case would also free rgd_buf that was already freed Signed-off-by: Juan Quintela <quint...@redhat.com> Signed-off-by: Anthony Liguori <aligu...@us.ibm.com> (cherry picked from commit a161329b61106ab093aab6d3227ac85e0b8251a9)
Conflicts: block/vmdk.c Signed-off-by: Kevin Wolf <kw...@redhat.com> --- block/vmdk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 4e48622..765e95a 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -285,7 +285,6 @@ static int vmdk_snapshot_create(const char *filename, const char *backing_file) goto fail_rgd; if (write(snp_fd, rgd_buf, gd_size) == -1) goto fail_rgd; - qemu_free(rgd_buf); /* write GD */ gd_buf = qemu_malloc(gd_size); @@ -298,6 +297,7 @@ static int vmdk_snapshot_create(const char *filename, const char *backing_file) if (write(snp_fd, gd_buf, gd_size) == -1) goto fail_gd; qemu_free(gd_buf); + qemu_free(rgd_buf); close(p_fd); close(snp_fd); -- 1.7.1.1