Am 22.06.2016 um 14:25 hat Alberto Garcia geschrieben: > Job IDs are generated automatically when a new job is created. This > patch adds a new 'job_id' parameter to let the caller provide one > instead. In this case the ID is verified to be unique and well-formed. > > Signed-off-by: Alberto Garcia <be...@igalia.com> > Reviewed-by: Max Reitz <mre...@redhat.com>
> @@ -140,7 +151,7 @@ void *block_job_create(const BlockJobDriver *driver, > BlockDriverState *bs, > > job->driver = driver; > job->device = g_strdup(bdrv_get_device_name(bs)); > - job->id = id_generate(ID_JOB); > + job->id = job_id ? g_strdup(job_id) : id_generate(ID_JOB); > job->blk = blk; > job->cb = cb; > job->opaque = opaque; This hunk will trivially conflict with removing device names. You can keep my R-b while resolving that. Reviewed-by: Kevin Wolf <kw...@redhat.com>
