On 06/17/2016 01:54 AM, Markus Armbruster wrote: >>> >>> I'll take this one through qapi-next. Thanks! >>> >> >> You may want to squash this in for shorter lines: >> >> >> diff --git a/qobject/json-lexer.c b/qobject/json-lexer.c >> index de16219..b030576 100644 >> --- a/qobject/json-lexer.c >> +++ b/qobject/json-lexer.c >> @@ -21,16 +21,14 @@ >> * Required by JSON (RFC 7159), plus \' extension in "", and extension >> * of parsing case-insensitive non-finite numbers like "NaN" and "-Inf": >> * >> - * \"([^\\\"]|(\\\"|\\'|\\\\|\\/|\\b|\\f|\\n|\\r|\\t| >> - * \\u[0-9a-fA-F][0-9a-fA-F][0-9a-fA-F][0-9a-fA-F]))*\" >> + * \"([^\\\"]|\\[\"'\\/bfnrt]|\\u[0-9a-fA-F]{4})*\"
> Doesn't apply as is, but I get what you mean. Applied to qapi-next, > please double-check the result there. Thanks! You lost the comment about 'plus \' extension in ""', which is probably still worth keeping; but otherwise looks okay. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature