On Thu, 06/16 09:58, Denis V. Lunev wrote:
> This is mandatory for correct backup creation. In the other case the
> content under this area would be lost.
>
> Dirty bits are set exactly like in bdrv_aligned_pwritev, i.e. they are set
> even if notifier has returned a error.
>
> Signed-off-by: Denis V. Lunev <d...@openvz.org>
> CC: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com>
> CC: Stefan Hajnoczi <stefa...@redhat.com>
> CC: Fam Zheng <f...@redhat.com>
> CC: Kevin Wolf <kw...@redhat.com>
> CC: Max Reitz <mre...@redhat.com>
> ---
> block/io.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/block/io.c b/block/io.c
> index 513bd99..92d9fe3 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -2266,6 +2266,11 @@ int coroutine_fn bdrv_co_discard(BlockDriverState *bs,
> int64_t sector_num,
> tracked_request_begin(&req, bs, NULL, sector_num << BDRV_SECTOR_BITS,
> nb_sectors << BDRV_SECTOR_BITS,
> BDRV_TRACKED_DISCARD);
>
> + ret = notifier_with_return_list_notify(&bs->before_write_notifiers,
> &req);
> + if (ret < 0) {
> + goto out;
> + }
> +
> max_discard = MIN_NON_ZERO(bs->bl.max_discard, BDRV_REQUEST_MAX_SECTORS);
> while (nb_sectors > 0) {
> int ret;
> --
> 2.5.0
>
Reviewed-by: Fam Zheng <f...@redhat.com>
