On Fri, Jul 09, 2010 at 08:46:33AM +0200, Markus Armbruster wrote:
> Isaku Yamahata <yamah...@valinux.co.jp> writes:
>
> > Fix leak in pci_unregister_secondary_bus().
> > call qbus_free().
> >
> > Signed-off-by: Isaku Yamahata <yamah...@valinux.co.jp>
> > ---
> > hw/pci.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/hw/pci.c b/hw/pci.c
> > index a7ff566..25634ed 100644
> > --- a/hw/pci.c
> > +++ b/hw/pci.c
> > @@ -298,6 +298,7 @@ static void pci_unregister_secondary_bus(PCIBus *bus)
> > {
> > assert(QLIST_EMPTY(&bus->child));
> > QLIST_REMOVE(bus, sibling);
> > + qbus_free(&bus->qbus);
> > }
> >
> > int pci_bus_num(PCIBus *s)
>
> Buses are normally freed automatically along with the device providing
> them, in qdev_free(). Why is that not sufficient for pci-bridge?
>
Right. I withdraw this patch.
Sorry for noise.
--
yamahata
