On Wed, Jun 08, 2016 at 02:01:23PM +0200, Paolo Bonzini wrote: > > > On 02/06/2016 18:46, Daniel P. Berrange wrote: > > Currently the QmpInputVisitor assumes that all scalar > > values are directly represented as their final types. > > ie it assumes an 'int' is using QInt, and a 'bool' is > > using QBool. > > > > This extends it so that QString is optionally permitted > > for any of the non-string scalar types. This behaviour > > is turned on by requesting the 'autocast' flag in the > > constructor. > > > > This makes it possible to use QmpInputVisitor with a > > QDict produced from QemuOpts, where everything is in > > string format. > > Perhaps this should instead be a separate QmpStringInputVisitor visitor > that _only_ accepts strings? You can reuse most of the QmpInputVisitor > by putting it in the same file, because the struct and list visitors are > compatible.
Yes, that actually works out quite nicely indeed, and in fact showed up a bug in my unit tests too :-) Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
