Christoph Hellwig <h...@lst.de> writes: > On Tue, Jul 06, 2010 at 02:08:49PM +0200, Markus Armbruster wrote: >> drive_init() doesn't permit rerror for if=scsi, but that's worthless: >> we get it via if=none and -device. >> >> Moreover, scsi-generic doesn't support werror. Since drive_init() >> doesn't catch that, option werror was silently ignored even with >> if=scsi. >> >> Wart: unlike drive_init(), we don't reject the default action when >> it's explicitly specified. That's because we can't distinguish "no >> rerror option" from "rerror=report", or "no werror" from >> "rerror=enospc". Left for another day. > > I can't see a good reason that scsi doesn't support the rerror option, > and implementing is trivial. So while this patch looks correct I'd > rather see rerror implemented for scsi than hacking around the lack of > it.
You got a point there. Same for fdc. However, this is the best *I* can do in time for .13. Let's add the missin error action support after the release, okay?
