On 8 June 2016 at 21:24, Laurent Vivier <laur...@vivier.eu> wrote: > Signed-off-by: Laurent Vivier <laur...@vivier.eu> > --- > linux-user/strace.c | 25 ++++++++++++++----------- > 1 file changed, 14 insertions(+), 11 deletions(-)
I think this change is correct, but it would be clearer to read if we defined a do_print_clone() that did the actual printing and took arguments in the same order as the do_fork() function in syscall.c. Then it would be easy to compare the syscall.c and this code to check they pass the arguments in the same order to the function that does the work. (Also, naming the arguments here arg1..arg6 rather than arg0..arg5 would make them match syscall.c.) thanks -- PMM
