On 06/06/2016 17:16, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > --- > target-i386/cpu.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index f791a06..31e5e6f 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -1975,6 +1975,9 @@ static void x86_cpu_parse_featurestr(CPUState *cs, char > *features, > error_propagate(errp, local_err); > return; > } > + fprintf(stderr, > + "'+%s' is obsolete and will be removed in future, use > '%s=on'", > + featurestr + 1, featurestr + 1);
Could you detect using +foo together with foo=off, and -foo together with foo=on? Those are the really problematic cases, without them +foo and -foo can become synonyms for =on and =off. Paolo > continue; > } else if (featurestr[0] == '-') { > add_flagname_to_bitmaps(featurestr + 1, minus_features, > &local_err); > @@ -1982,6 +1985,9 @@ static void x86_cpu_parse_featurestr(CPUState *cs, char > *features, > error_propagate(errp, local_err); > return; > } > + fprintf(stderr, > + "'-%s' is obsolete and will be removed in future, use > '%s=off'", > + featurestr + 1, featurestr + 1); > continue; > } > >