On Fri, 05/27 11:57, Max Reitz wrote: > On 27.05.2016 09:48, Fam Zheng wrote: > > On Tue, 05/24 18:28, Max Reitz wrote: > > [...] > > >> Also: Should bdrv_reopen_prepare() check that the locking flags are not > >> changed? > > > > Read only flag also matters in fcntl locks, so practically we almost always > > need some change on the lock. > > Hm, but as far as I can see, you don't handle changed locking flags > here; the reopened image is just locked if the old one had been locked > before. Since the handling of BDRV_O_SHARED_LOCK is done in > bdrv_lock_unlock_image_do(), that means that BDRV_O_NO_LOCK is ignored > if changed, isn't it?
Yes you are rigth. I'm reworking this patch and it should fix this problem too. Fam
