On 27/05/2016 04:13, xiaoqiang zhao wrote: > > > 在 2016年05月25日 21:15, Paolo Bonzini 写道: >>>>> @@ -310,8 +312,7 @@ static void pl011_class_init(ObjectClass *oc, >>>>> void *data) >>>>> >> > >>>>> >> > dc->realize = pl011_realize; >>>>> >> > dc->vmsd = &vmstate_pl011; >>>>> >> >- /* Reason: realize() method uses >>>>> qemu_char_get_next_serial() */ >>>>> >> >- dc->cannot_instantiate_with_device_add_yet = true; >>> >Why does instantiating with device_add work now? There's >>> >still no way to wire up interrupt lines or map mmio regions. >>> >(This has never made much sense to me -- Markus?) >> You can create it with -device if your board provides a platform bus and >> there's an FDT creator function. If you don't, you get an error. >> >> Regarding device_add, it's disabled anyway because sysbus is not >> hotpluggable. >> >> Eiter way it's safe to remove this line, which is for outliers that >> otherwise would not give any error message. > Paolo: Do I need to send a new version to keep the > > "dc->cannot_instantiate_with_device_add_yet = true" > untouched ?
No, you should remove it. cannot_instantiate_with_device_add_yet is set if you cannot_instantiate_with_device_add_yet *and* there is no code elsewhere to detect that. Thanks, Paolo
