On Tue, Jun 29, 2010 at 7:44 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > On 06/28/2010 10:29 PM, Paul Brook wrote: >>> >>> diff --git a/exec-all.h b/exec-all.h >>> index a775582..ebe88ad 100644 >>> --- a/exec-all.h >>> +++ b/exec-all.h >>> @@ -353,4 +353,8 @@ extern int singlestep; >>> /* cpu-exec.c */ >>> extern volatile sig_atomic_t exit_request; >>> >>> +#ifdef NEED_GLOBAL_ENV >>> +register CPUState *env asm(AREG0); >>> +#endif >> >> Wouldn't it be better to just put this in dyngen-exec.h ? >> AFAICT there's a direct correlation between NEED_GLOBAL_ENV and #include >> "exec.h". > > True, see cover letter in 0/4. I was told to make each file request > explicitly the global variable though. So I'd have to leave the #ifdef even > if I moved it into dyngen-exec.h.
Well, I only said I'd rename global 'env' to 'global_reg_env', not something about each file requesting it. But NEED_GLOBAL_ENV wasn't so bad idea in my opinion.
