On Thu, 19 May 2016 10:24:00 -0500 miny...@acm.org wrote: > From: Corey Minyard <cminy...@mvista.com> > > Add an IPMI table entry to the SMBIOS. > > Signed-off-by: Corey Minyard <cminy...@mvista.com> > Acked-by: Michael S. Tsirkin <m...@redhat.com> > --- > hw/smbios/Makefile.objs | 2 + > hw/smbios/ipmi.c | 114 > +++++++++++++++++++++++++++++++++++++++++++++++ > hw/smbios/noipmi.c | 14 ++++++ > hw/smbios/smbios.c | 2 + > include/hw/smbios/ipmi.h | 15 +++++++ > 5 files changed, 147 insertions(+) > create mode 100644 hw/smbios/ipmi.c > create mode 100644 hw/smbios/noipmi.c > create mode 100644 include/hw/smbios/ipmi.h > > diff --git a/hw/smbios/Makefile.objs b/hw/smbios/Makefile.objs > index f69a92f..5578f51 100644 > --- a/hw/smbios/Makefile.objs > +++ b/hw/smbios/Makefile.objs > @@ -1 +1,3 @@ > common-obj-$(CONFIG_SMBIOS) += smbios.o > +common-obj-$(call land,$(CONFIG_SMBIOS),$(CONFIG_IPMI)) += ipmi.o > +common-obj-$(call land,$(CONFIG_SMBIOS),$(call lnot,$(CONFIG_IPMI))) += > noipmi.o why not use existing stub approach instead of adding conditional for noipmi.o?
[...] > diff --git a/hw/smbios/noipmi.c b/hw/smbios/noipmi.c this file should be in a/hw/stubs/ and maybe s/noipmi.c/smbios_type_38.c/ > new file mode 100644 > index 0000000..ad669a4 > --- /dev/null > +++ b/hw/smbios/noipmi.c > @@ -0,0 +1,14 @@ > +/* > + * IPMI SMBIOS firmware handling > + * > + * Copyright (c) 2015 Corey Minyard, MontaVista Software, LLC > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + */ > + > +#include "hw/smbios/ipmi.h" > + > +void smbios_build_type_38_table(void) > +{ > +} [...]