On Mi, 2016-05-11 at 17:22 +0800, Wang Xin wrote: > Commit bfa0f15 add vbe_enabled() helper, while it forget to replace > the code in vbe_ioport_write_data().
> case VBE_DISPI_INDEX_ENABLE: > - if ((val & VBE_DISPI_ENABLED) && > - !(s->vbe_regs[VBE_DISPI_INDEX_ENABLE] & VBE_DISPI_ENABLED)) { I left it there as-is intentionally, because that is the place where VBE is actually enabled and I think the code is easier to read if the logic at that location isn't hidden by the helper. cheers, Gerd