On Fri, Apr 22, 2016 at 07:42:29PM +0200, Kevin Wolf wrote: > This is another feature that was "logically" part of the BlockBackend, but > implemented as a BlockDriverState feature. It was always kept on top using > swap_feature_fields(). > > This series moves it to be actually implemented in the BlockBackend, removing > another obstacle for removing bs->blk and allowing multiple BBs per BDS. > > Applies to block-next. > > v2: > - Rebased on top of Paolo's 'bdrv_flush_io_queue removal, shared > LinuxAioState' > Most notable this includes a complete rewrite of patch 9 (was 10): 'block: > Drain throttling queue with BdrvChild'. Instead of a single drain_queue() > callback we now have a drained_begin/end() pair. > > - Patch 2 (was 3): 'block: Introduce BlockBackendPublic' > Add int dummy to yet empty struct BlockBackendPublic [Eric] > > - Patch 11: 'block: Remove bdrv_move_feature_fields()' > After the rebase, the function ended up empty, we can remove it now > > - Patch 12: 'Revert "block: Forbid I/O throttling on nodes with > multiple parents for 2.6"' > This was committed to master after v1 had been posted, so this one is new as > well. The reason for forbidding this was that patch 6 ('block: Move actual > I/O throttling to BlockBackend') would change the behaviour of the non-BB > parents. Now that the final behaviour is implemented, we can allow the > setup.
I have posted comments. Looks good overall.
signature.asc
Description: PGP signature