Luiz Capitulino <lcapitul...@redhat.com> writes: > On Wed, 23 Jun 2010 17:23:54 +0200 > Markus Armbruster <arm...@redhat.com> wrote: > >> Luiz Capitulino <lcapitul...@redhat.com> writes: [...] >> > + qerror_report(QERR_QMP_UNEXPECTED_INPUT_OBJECT_MEMBER, >> > arg_name); >> >> Identifier's a bit on the long side, isn't it? > > Yes, suggestions?
What about omitting INPUT_OBJECT or at least OBJECT? EXTRA instead of UNEXPECTED? We could have QERR_QMP_EXTRA_MEMBER QERR_QMP_MISSING_MEMBER now: QERR_QMP_BAD_INPUT_OBJECT (I think) QERR_QMP_BAD_MEMBER now: QERR_QMP_BAD_INPUT_OBJECT_MEMBER [...]