On 20 April 2016 at 18:16, Emilio G. Cota <c...@braap.org> wrote: > On Wed, Apr 20, 2016 at 14:15:41 +0200, KONRAD Frederic wrote: >> Le 20/04/2016 01:07, Emilio G. Cota a écrit : >> >Taken from the linux kernel. >> > >> >Reviewed-by: Richard Henderson <r...@twiddle.net> >> >Signed-off-by: Emilio G. Cota <c...@braap.org> >> >--- >> > include/qemu/processor.h | 28 ++++++++++++++++++++++++++++ >> > 1 file changed, 28 insertions(+) >> > create mode 100644 include/qemu/processor.h >> > >> >diff --git a/include/qemu/processor.h b/include/qemu/processor.h >> >new file mode 100644 >> >index 0000000..675a00a >> >--- /dev/null >> >+++ b/include/qemu/processor.h >> >@@ -0,0 +1,28 @@ >> >> Hi, >> >> Does this file need a license? > > I figured GPLv2 would apply to it by default. However, IANAL so I'd > be happy to add a line to the patch stating the file is covered under > GPLv2.
Yeah, in general we prefer new files to have at least a short copyright-and-license statement, though there are some older files (particularly headers) without. thanks -- PMM