On 04/15/2016 06:06 PM, Paolo Bonzini wrote:


Here's my try rewording the comment (sticking to GTK-Doc conventions
even though I dislike them):

/**
  * @qdev_property_add_static:
  * @dev: Device to add the property to
  * @prop: The qdev property definition
  * @err: location to store error information
  *
  * Add a static QOM property to @dev for qdev property @prop.
  * On error, store error in @errp.
  */

Paolo, is it correct?

Yes, it is.  You can add also "The type of the QOM property is derived
from prop->info", which is what Cao Jin really wanted to convey in his
patch.

Paolo


Thanks Paolo for your explanation, much useful info for me:)

I will collect Markus`s rewording and your suggestion into v2 later.

--
Yours Sincerely,

Cao jin



Reply via email to