On 14.04.2016 12:20, Denis V. Lunev wrote: > From: Pavel Butsykin <pbutsy...@virtuozzo.com> > > From time to time qemu-nbd is crashing on the following assert: > assert(state == TERMINATING); > nbd_export_closed > nbd_export_put > main > and the state at the moment of the crash is evaluated to TERMINATE. > > During shutdown process of the client the nbd_client_thread thread sends > SIGTERM signal and the main thread calls the nbd_client_closed callback. > If the SIGTERM callback will be executed after change the state to > TERMINATING, then the state will once again be TERMINATE. > > To solve the issue, we must change the state to TERMINATE only if the state > is RUNNING. In the other case we are shutting down already. > > Signed-off-by: Pavel Butsykin <pbutsy...@virtuozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Paolo Bonzini <pbonz...@redhat.com> > --- > qemu-nbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks Pavel and Denis, I have applied the patch to my block tree: https://github.com/XanClic/qemu/commits/block Max
signature.asc
Description: OpenPGP digital signature
