On 04/11/2016 09:19 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > include/hw/virtio/virtio-input.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-)
An explanation would have been helpful. > #if defined(HOST_WORDS_BIGENDIAN) > # define const_le32(_x) \ > - (((_x & 0x000000ffU) << 24) | \ The problem you are fixing is that _x needs parenthesis. > + ((((_x) & 0x000000ffU) << 24) | \ and you indeed added it, but I had to hunt because there was no explanation in the commit message. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
