On Thu, Jun 17, 2010 at 02:57:16PM +0300, Michael S. Tsirkin wrote: > On Thu, Jun 17, 2010 at 01:02:43PM +0300, Michael S. Tsirkin wrote: > > For example, forcing all devices to call pci_reset_default > > in their reset routines does not look like a good cleanup: > > the less boilerplate, the better IMO. > > One thing that we need to address, is devices > which need to enable memory+master on init. > They should probably also enable this on reset.
Isn't it BIOS/firmware that initializes those bits? And seabios does so. The pci spec explicitly says that they are 0 after RST#. > One approach that was discussed several times > would be to call cleanup and then init again. > I expect this would be enough to get rid of reset > callbacks in most devices. Oh, some devices set those bits on init. So cleanup + init again might be easier than sorting out initialization/reset of each devices. thanks, > > -- > MST > -- yamahata
