* Li Zhijian (lizhij...@cn.fujitsu.com) wrote:
>
>
> On 03/30/2016 07:41 PM, Dr. David Alan Gilbert wrote:
> [...]
>
> >>>@@ -433,7 +532,9 @@ static void compare_pri_chr_in(void *opaque, const
> >>>uint8_t *buf, int size)
> >>> if (ret == 1) {
> >>> if (packet_enqueue(s, PRIMARY_IN)) {
> >>> error_report("primary: unsupported packet in");
> >>>- compare_chr_send(s->chr_out, buf, size);
> >>>+ compare_chr_send(s->chr_out, s->pri_rs.buf,
> >>>s->pri_rs.packet_len);
> >Doesn't that change belong in an earlier patch?
> >
> >>>+ } else {
> >>>+ qemu_event_set(&s->event);
> >Also these - why are these in this patch?
> This event is to wakeup comparison thread to do compare.
> Do you think we should put event related code to patch 2 ?
Ah OK; yes the event_set makes sense in this patch.
Dave
> Thanks
> Li
> >
> >>> }
>
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
