On 03/30/2016 09:36 AM, Samuel Thibault wrote: > Thomas Huth, on Wed 30 Mar 2016 17:29:12 +0200, wrote: >> On 30.03.2016 17:13, Samuel Thibault wrote: >>> Thomas Huth, on Wed 30 Mar 2016 17:06:51 +0200, wrote: >>>> The "restrict" option is listed with "=on|off" here, that's why I >>>> thought it should be there for "ipv4" and "ipv6", too. Which boolean >>>> options are missing the "=on|off" ? >>> >>> All the ipv4 and ipv6 options in the same file. >> >> Ugh, ok, now I see it ... most of these are specified in qemu-options.hx >> without the "=on|off", only for the "-netdev l2tpv3" it is specified as >> "ipv6=on/off" (with slash instead of the pipe character!) ... what a >> mess... not sure which is the best way to go here, so maybe keep it >> without the "=on|off" for now so that it is consistent with most of the >> other options? > > Eric, Markus, what do you prefer?
No strong preference. Libvirt doesn't parse the command line --help output, precisely because (as you've noticed) it is a big inconsistent mess already. Pick one, and that's fine; and it's a bonus if you want to do a followup cleanup for consistency, but I won't lose any sleep if you don't do a followup. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
