On Wed, 30 Mar 2016 14:48:02 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote:
> The missing check on dataplane_disabled caused a segmentation > fault in notify_guest_bh, because s->guest_notifier was NULL. I think this patch description could be improved :) "We must not call virtio_blk_data_plane_notify if dataplane is disabled: we would hit a segmentation fault in notify_guest_bh as s->guest_notifier has not been setup and is NULL." ? > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > hw/block/dataplane/virtio-blk.c | 7 +++---- > hw/block/virtio-blk.c | 2 +- > include/hw/virtio/virtio-blk.h | 1 + > 3 files changed, 5 insertions(+), 5 deletions(-) Patch looks good: Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>
